ProsePoint Express: hosted newspaper website content management software

Image insert window

  • strict warning: Non-static method view::load() should not be called statically in /home/prosepoint.org/bzr/public_html/profiles/prosepoint/modules/views/views.module on line 879.
  • strict warning: Declaration of views_handler_argument::init() should be compatible with views_handler::init(&$view, $options) in /home/prosepoint.org/bzr/public_html/profiles/prosepoint/modules/views/handlers/views_handler_argument.inc on line 0.
  • strict warning: Declaration of views_handler_filter::options_validate() should be compatible with views_handler::options_validate($form, &$form_state) in /home/prosepoint.org/bzr/public_html/profiles/prosepoint/modules/views/handlers/views_handler_filter.inc on line 0.
  • strict warning: Declaration of views_handler_filter::options_submit() should be compatible with views_handler::options_submit($form, &$form_state) in /home/prosepoint.org/bzr/public_html/profiles/prosepoint/modules/views/handlers/views_handler_filter.inc on line 0.
  • strict warning: Declaration of views_handler_filter_node_status::operator_form() should be compatible with views_handler_filter::operator_form(&$form, &$form_state) in /home/prosepoint.org/bzr/public_html/profiles/prosepoint/modules/views/modules/node/views_handler_filter_node_status.inc on line 0.
  • strict warning: Non-static method view::load() should not be called statically in /home/prosepoint.org/bzr/public_html/profiles/prosepoint/modules/views/views.module on line 879.
  • strict warning: Declaration of views_handler_filter_boolean_operator::value_validate() should be compatible with views_handler_filter::value_validate($form, &$form_state) in /home/prosepoint.org/bzr/public_html/profiles/prosepoint/modules/views/handlers/views_handler_filter_boolean_operator.inc on line 0.
  • strict warning: Declaration of date_api_filter_handler::value_validate() should be compatible with views_handler_filter::value_validate($form, &$form_state) in /home/prosepoint.org/bzr/public_html/profiles/prosepoint/modules/date/includes/date_api_filter_handler.inc on line 0.
  • strict warning: Non-static method view::load() should not be called statically in /home/prosepoint.org/bzr/public_html/profiles/prosepoint/modules/views/views.module on line 879.
  • strict warning: Declaration of views_plugin_row::options_validate() should be compatible with views_plugin::options_validate(&$form, &$form_state) in /home/prosepoint.org/bzr/public_html/profiles/prosepoint/modules/views/plugins/views_plugin_row.inc on line 0.
  • strict warning: Declaration of views_plugin_row::options_submit() should be compatible with views_plugin::options_submit(&$form, &$form_state) in /home/prosepoint.org/bzr/public_html/profiles/prosepoint/modules/views/plugins/views_plugin_row.inc on line 0.
3 replies [Last post]
dbell154
dbell154's picture
User offline. Last seen 7 years 25 weeks ago. Offline
Joined: 11/05/2009
Posts:

This is something of a backwards wishlist. I made the change to my copy, but wanted to post it so you can consider making the change in the original.

The image upload window allows you to enter a caption of 512 characters long, while the image insert windoow only allows the default 128 characters. Also, you have to enter the caption in both windows. I made changes in the file to allow 512 characters in the image insert window, and to get the caption from the previous image upload window. I also changed it to use textarea instead of txtfield.

Here's the original and the modification to the code in pp_ed.image.inc in the prosepoint_editor folder, starting at line 199

Original (I think)

$form['caption'] = array(
'#title' => t('Caption'),
'#type' => 'txtfield',
'#default_value' => $_GET['caption'],
);

Change

$form['caption'] = array(
'#title' => t('Caption'),
'#type' => 'textarea',
'#rows' => '3',
'#maxlength' => '512',
'#default_value' => $_GET['caption'] ? $_GET['caption'] : $node->body,
);

 

beng
User offline. Last seen 4 years 31 weeks ago. Offline
Joined: 27/02/2009
Posts:
They are actually two different things

Hi,

The reason there are two 'captions' is because they are actually two different things, and used in two different ways.

The caption when you upload a new image (ie. create a new image node) is associated with the node and displayed when the image node itself is viewed.

The caption when you insert an image into a story is displayed only when that story is viewed.

I figured there would be some cases where you may want to have the same image appear in different stories and wanted different captions ie. you are using an existing image (that was originally uploaded for a story in the past) for a new story, and hencce the caption would be different.

In hindsight, probably I should not have used the same terminology for both quantities.

dbell154
dbell154's picture
User offline. Last seen 7 years 25 weeks ago. Offline
Joined: 11/05/2009
Posts:
I understand. Yes, I knew

I understand. Yes, I knew they were different. But, when I post a story and add a photo, it's handy to be able to enter the one caption and have it initially used for both purposes. If you edit the caption in the second window, that's the one that will be used in the story. Maybe a button, or checkbox that optionally copies the caption from the image node could be used...

That was just the bonus, though. The thing that I was happy about was being able to have longer captions in stories when I insert the image.

BTW, Is there a plan to include a photo credit field, like the source in a story? We've been including the credit as part of the caption text A separate field would enable me to format it differently, i.e. right-justified in a different font.

beng
User offline. Last seen 4 years 31 weeks ago. Offline
Joined: 27/02/2009
Posts:
...

Hi,

Sorry, but your changes didn't make it in time for the 0.24 release. I'd been pulled away to work on something else for the last few weeks, and didn't make any changes as per your suggestion. Then the security announcement came along and I had to release in a hurry.

I think, you'll mostly likely want to make that same change again (if you upgrade to 0.24).

I agree with defaulting the 'image insert caption' to be the same as the 'image node caption'. Not entirely decided yet on changing the 'image insert caption' from a textfield to a textarea. To be consistent, I should also change the 'image node caption' to a textarea as well, but this has other flow-on effects elsewhere which I'd rather not have to deal with ...

Here's a prospective compromise ... what if I create a small (ie. 10 lines ish) module for you which changes the 'image insert caption' to a textarea? This module would be an add-on to ProsePoint, but otherwise won't be affected by ProsePoint upgrades. Then you can have your textarea, and I can keep my changes to standard ProsePoint to a minimum. Thoughts?

Regarding a photo credit field ...

No, there isn't a plan to add a photo credit field to 'image inserted' images nor to image nodes. Is such a field just like another caption? I think I'd have to make sure the image outputs are themeable first, otherwise, even if such a field exists, you can't right-justify it.